Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DLC channel next to Lightning channel #126

Closed
luckysori opened this issue Feb 13, 2023 · 0 comments · Fixed by #152
Closed

Add DLC channel next to Lightning channel #126

luckysori opened this issue Feb 13, 2023 · 0 comments · Fixed by #152
Assignees
@holzeis @luckysori

Comments

@luckysori
Copy link
Contributor

We want to be able to use rust-dlc to "upgrade" an already-open Lightning to have a DLC channel next to it.

This task involves writing a passing test in ln_dlc_node.
@luckysori luckysori added the MVP label Feb 13, 2023
@luckysori luckysori mentioned this issue Feb 13, 2023
Closed
10 tasks
@luckysori luckysori mentioned this issue Feb 20, 2023
Merged
bors bot added a commit that referenced this issue Feb 21, 2023
@bors @holzeis
Merge #152
9fcfe9b 
152: Support creation of DLC channel r=luckysori a=luckysori

Fixes #126.

This currently single-patch PR includes too many things that I have not managed to split into smaller patches. I can spend some time doing so if the review is too hard.

Namely:

- Add new test to prove that we can open a DLC channel.
- Start refactoring the "production" code in `ln-dlc-node`.
- Rework all the tests in `ln-dlc-node`. The objective was to simplify and better understand why things work. This led to fixing a couple of bugs, and it made the tests faster and easier to read.
- Remove `system_tests` feature in favour of `#[ignore]` attributes.

The DLC functionality still needs to be tested more e.g. can we make a payment after opening a DLC channel.

Co-authored-by: Richard Holzeis <richard@holzeis.me>
@bors bors bot closed this as completed in 55bee47 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holzeis holzeis

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support creation of DLC channel get10101/10101
2 participants
@holzeis @luckysori