feat: Rollover DLC #1122
feat: Rollover DLC #1122
Conversation
holzeis
force-pushed
the
feat/rollover-dlc
branch
3 times, most recently
from
a4268f4 to
8f30240
Compare
| ) | ||
| } | ||
|
|
||
| /// Finalizes the rollover protocol with the app setting the position to open. |
There was a problem hiding this comment.
🔧 This talks about the app but this is coordinator code.
There was a problem hiding this comment.
well the coordinator talks with the app to finalize the rollover protocol. what would you want to change here?
There was a problem hiding this comment.
I thought you were meaning to say that the coordinator would set the position to open.
There was a problem hiding this comment.
Yes it does set it from Rollover to Open 😅
There was a problem hiding this comment.
Okay, I see why I was confused now. I read
Finalizes the rollover protocol**,** with the app setting the position to open
which is weird because this is coordinator code. But you meant
Finalizes the rollover protocol with the app**,** setting the position to open
which makes sense. I think the comma would help, but it's not important.
IMHO this is a bit cleaner as the api is simplified if we just call the calculate_settlement_amount on the position.
It appears the channel_id is not always correct. Using the `get_dlc_channel_id(0)` seems to cover more edge cases.
This introduces the rollover of a signed dlc. It uses the renew offer api of the rust dlc. A couple of design choices. - The payout amount is calculated from the original average entry price - as we are rolling over a position nothing should change. However, this is most likely the place where we would like to add paying the funding rates for the rollover. - The state `Rollover` is introduced to the position on the coordinator and the app side. It helps to show a rollover in progress as with the dlc creation a lot of messages are exchanged in between. We also need that state to prevent the coordinator from accidentally setting the position to `Closed` as the underlying contract is Closed after the new one is set. Therefore the `temporary_contract_id` is also updated. I left a some todos regarding the dlc messages. It would be nice if we could process them similar to the lightning messages through the or a event handler. That would allow for the design to be nicer decoupled.
holzeis
force-pushed
the
feat/rollover-dlc
branch
from
92ca89f to
6b20ca3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This introduces the rollover of a signed dlc. It uses the renew offer api of the rust dlc.
The payout amount is calculated from the original average entry price - as we are rolling over a position nothing should change. However, this is most likely the place where we would like to add paying the funding rates for the rollover.
The state
Rolloveris introduced to the position on the coordinator and the app side. It helps to show a rollover in progress as with the dlc creation a lot of messages are exchanged in between. We also need that state to prevent the coordinator from accidentally setting the position toClosedas the underlying contract is Closed after the new one is set. Therefore thetemporary_contract_idis also updated.I left a some todos regarding the dlc messages. It would be nice if we could process them similar to the lightning messages through the or a event handler. That would allow for the design to be nicer decoupled.
resolves #1068