Add Synthetic USD balance into account overview #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
reviewed
Aug 25, 2023
holzeis
reviewed
Aug 25, 2023
There was a problem hiding this comment.
It's still weird to me that we show the synthetic usd balance in the wallet screen, because it does not match the transaction history showing an outgoing transaction.
Overall it does not feel consistent, maybe it would be better to first go to figma and have a look there? Also considering that this is not necessarily required for the experiment.
klochowicz
force-pushed
the
feat/stablesats-type-in-transactions
branch
from
4b1f063 to
4e788e4
Compare
Restioson
approved these changes
Aug 25, 2023
klochowicz
force-pushed
the
feat/stablesats-type-in-transactions
branch
3 times, most recently
from
1daa0bf to
cd4df74
Compare
Closed
A log entry whenever *any* event is being sent to Flutter, without any more
details than the event type was useless.
Synthetic USD balance is de-facto a new "wallet", therefore displaying the amount of stabilised USD makes sense.
klochowicz
force-pushed
the
feat/stablesats-type-in-transactions
branch
from
cd4df74 to
c83f3e6
Compare
Synthetic USD are shown in the overall balance (if we have any). This is just a suggestion, probably iterating this with the community would be best.
klochowicz
force-pushed
the
feat/stablesats-type-in-transactions
branch
from
c83f3e6 to
17531d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video.mov