-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drain on-chain wallet #1541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it works, although I am not a fan of misusing the amount input field for that.
Maybe a drain button, that fetches the max amount that can be spent and sets it into the amount field would be better?
Imho that's a defacto standard in Bitcoin wallets.
This is very hard to calculate in advance, you'd need to use the drain function first, then create the transaction, and then get the output's amount and return it back to the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bonomat I forgot that this screen is also used for sending lightning. I think your changes will not work in that case.
e0f825c
to
900bf0b
Compare
Resolves #1538