feat: Recover from pending offer #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
changed the title
4 tasks
holzeis
force-pushed
the
feat/recover-from-pending-offer
branch
from
2c03f3c to
fd09ce3
Compare
If something fails in the post processing the message should still be marked as processed. Note, that wouldn't be required if we'd use a proper database transaction for the whole function.
holzeis
force-pushed
the
feat/recover-from-pending-offer
branch
from
29bbc42 to
6dd74e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks on
on_connectif the current dlc channel status is in offered.OfferedChannel: Automatically tries to accept the offer, if that fails the offer is attempted to be rejected. I think we do not need to check the maturity date outside of accepting the offer as the offer will fail anyways if the maturity date is in the past. If so we are continuing with rejecting the dlc channel offer.SignedChannel(state: SettledReceived): Automatically accept the offer to close the position (settle the dlc channel)SignedChannel(state: CollaborativeCloseOffered): Automatically accept the offer to collab close the dlc channel.Future work
SignedChannel(state: RenewOffered): To be addressed with Allow users to resize a position #1791 .