Skip to content

feat: collaborative revert dlc channels #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2024
Merged

feat: collaborative revert dlc channels #1823

merged 3 commits into from
Jan 17, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Jan 16, 2024

resolves #1809

Tested manually.

https://drive.google.com/file/d/1798JHsB6gIOfUsmmcBNE8cpCVdoBIPrP/view?usp=sharing

@luckysori : how far are you with #1798? I thought I'd wait for your changes to add an e2e test for this feature.

@bonomat bonomat requested review from holzeis and luckysori January 16, 2024 16:03
@bonomat bonomat changed the title fix: diesel needs at least one sql command in these files or else thr… feat: collaborative revert dlc channels Jan 16, 2024
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like how everything get so much simpler :)

@bonomat bonomat force-pushed the feat/collab-revert branch from ce4bb03 to bde650c Compare January 17, 2024 14:47
@bonomat bonomat requested a review from holzeis January 17, 2024 14:49
@bonomat
Copy link
Contributor Author

bonomat commented Jan 17, 2024

@holzeis : please rereview

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bonomat bonomat added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit de2d93c Jan 17, 2024
@bonomat bonomat deleted the feat/collab-revert branch January 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement collab-revert for dlc-channels
2 participants