Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flickering prices #2379

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: flickering prices #2379

merged 3 commits into from
Apr 9, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Apr 9, 2024

resolves #2232
resolves #2370

bonomat added 3 commits April 9, 2024 12:05
Expired orders are being removed from the orderbook itself already and a delete message will be sent.
We fix flickering price update in the frontend by allowing ask/bid prices to be updated individually.
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 not sure though why this will fix the flickering price updates.

Did you verify that this is actually fixing it?

@bonomat
Copy link
Contributor Author

bonomat commented Apr 9, 2024

LGTM 👍 not sure though why this will fix the flickering price updates.

Did you verify that this is actually fixing it?

The flickering price came from us sending updates like this:

Price { bid: Some(71204.88), ask: None } which set one of the prices to 0 just before the next update came in.

I could have done a simple null check in the frontend... but where is the fun of that?

@bonomat bonomat added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 3b8d670 Apr 9, 2024
22 checks passed
@bonomat bonomat deleted the chore/flickering-price branch April 9, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flickering price updates Potential redundant delete of expired orders
2 participants