fix: ensure filling/filled orders have matching fee #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies our code as it removes genericism and makes things more explicit.
Done is the time with complex `into()`, hello simple code.
holzeis
approved these changes
Apr 9, 2024
mobile/native/migrations/2024-04-09-105312_ensure_old_orders_have_matching_fee/up.sql
Outdated
Show resolved
Hide resolved
…ave_matching_fee/up.sql Co-authored-by: Richard Holzeis <richard@holzeis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2382 (hopefully).
It ensures that this bug cannot happen again and sets the matching fee for existing orders in the db.
My interpretation is that this error came from the fact that we introduced a new field
matching_fee_satswhich was obviously not set for existing orders.