Add trader_pnl to trade_params table
#2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allowing to insert trades early into the database (via the `is_complete` column, which is now gone).
bonomat
reviewed
Apr 10, 2024
| } | ||
|
|
||
| impl From<(ProtocolId, &commons::TradeParams)> for TradeParams { | ||
| fn from((protocol_id, trade_params): (ProtocolId, &commons::TradeParams)) -> Self { | ||
| impl TradeParams { |
luckysori
force-pushed
the
chore/move-pnl-to-trade-params
branch
from
ed44ae8 to
a6a8c8e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
luckysori
force-pushed
the
chore/move-pnl-to-trade-params
branch
from
a6a8c8e to
7b246a7
Compare
We can now differentiate between opening a channel, opening a position and resizing a position.
luckysori
force-pushed
the
chore/move-pnl-to-trade-params
branch
from
7b246a7 to
16d5150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2359 (comment).