Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nag user to share referral code #2395

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Apr 10, 2024

This dialog will be shown on first app start and then every 7 days

Resolves #a-ticket-which-has-not-been-created-but-I-m-sure-we-want-this-feature

Image is in portrait mode and should be optimized for twitter line.

Simulator.Screen.Recording.-.iPhone.15.-.2024-04-10.at.16.19.28.mp4

also fixes #2399

@holzeis
Copy link
Contributor

holzeis commented Apr 10, 2024

I like it but maybe instead of showing it every 7 days we could show it after the user made a trade. I don't think that a user is going to refer the app the first time they open it. Or its the first thing they want to see when opening the app.

@SXBT69 what do you think?

@luckysori luckysori changed the title feat: Neg user to share referral code feat: Nag user to share referral code Apr 10, 2024
@bonomat bonomat force-pushed the feat/referral-info-dialog branch from 0a32553 to 6c89996 Compare April 10, 2024 10:53
@bonomat
Copy link
Contributor Author

bonomat commented Apr 10, 2024

I like it but maybe instead of showing it every 7 days we could show it after the user made a trade. I don't think that a user is going to refer the app the first time they open it. Or its the first thing they want to see when opening the app.

@SXBT69 what do you think?

Done in 6c89996 (#2395). If the user has a single trade and comes back onto the wallet screen we show him the dialog.

@bonomat bonomat enabled auto-merge April 10, 2024 10:54
@bonomat bonomat disabled auto-merge April 10, 2024 10:54
@SXBT69
Copy link
Contributor

SXBT69 commented Apr 10, 2024

I like it but maybe instead of showing it every 7 days we could show it after the user made a trade. I don't think that a user is going to refer the app the first time they open it. Or its the first thing they want to see when opening the app.

@SXBT69 what do you think?

Agreed. Adding this referal code to the "BRAG THE BAG MEME" would be even better 🔥
Do we have already a screen during the onboarding flow to enter the referal code? #2402

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@holzeis holzeis added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit b8facae Apr 11, 2024
22 checks passed
@holzeis holzeis deleted the feat/referral-info-dialog branch April 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fee rabate is shown as 0,20% instead of 20%
3 participants