Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show the number of seed words correctly (don't split across lines) #2610

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Restioson
Copy link
Contributor

Fixes #2443

@Restioson
Copy link
Contributor Author

Restioson commented Jun 5, 2024

The 2nd commit that I added also makes the layout shift less when clicking the visibility button. It slightly changes the alignment, so I'm happy to drop the commit if we don't like it.

Before:
before.webm

After:
after.webm

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Restioson Restioson added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit f632f0e Jun 12, 2024
23 checks passed
@Restioson Restioson deleted the fix/seed-phrase-ui branch June 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seedphrase : UI problem
3 participants