Merge pull request #196 from getAlby/task-qr-scanner

fix: prevent state updates in parent while rendering qrcodescanner
getAlby · Nov 22, 2024 · 93d709b · 93d709b
2 parents 6a6cfb0 + 9ca2546
commit 93d709b
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/components/QRCodeScanner.tsx b/components/QRCodeScanner.tsx
@@ -41,14 +41,11 @@ function QRCodeScanner({
   }
 
   const handleScanned = (data: string) => {
-    setScanning((current) => {
-      if (current === true) {
-        console.info(`Bar code with data ${data} has been scanned!`);
-        onScanned(data);
-        return true;
-      }
-      return false;
-    });
+    if (isScanning) {
+      console.info(`Bar code with data ${data} has been scanned!`);
+      onScanned(data);
+      setScanning(false);
+    }
   };
 
   return (