Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to delete not connected wallets #92

Closed
stackingsaunter opened this issue Sep 6, 2024 · 8 comments
Closed

Allow to delete not connected wallets #92

stackingsaunter opened this issue Sep 6, 2024 · 8 comments

Comments

@stackingsaunter
Copy link

If there's no working NWC link you cannot delete the wallet now (it moves to scanner)

@stackingsaunter
Copy link
Author

Ah you actually can, but first you need to select it and then go to wallets and click settings

@bumi
Copy link

bumi commented Sep 11, 2024

I failed doing this, too (and wanted to create the same issue)

can we support swipping to delete? like in messenger apps? (it at least is a pattern on iOS)

@stackingsaunter
Copy link
Author

That would be awesome actually. @bumi I'll come up with design

@reneaaron
Copy link
Contributor

I don't think there should be any distinction between wallets & connection strings in the app. I think from a user's perspective it's a lot easier to understand if this is one entity and you can just delete a wallet (but not disconnect it).

@bumi
Copy link

bumi commented Sep 16, 2024

+1 I just wanted to delete a connection/wallet whatever it is called.

@reneaaron
Copy link
Contributor

Fixed with #122

@rolznz
Copy link
Contributor

rolznz commented Sep 17, 2024

I wonder it's a bit strange that a wallet can be created without a connection string. Maybe wallets should only be created when a valid connection string is given.

@bumi
Copy link

bumi commented Sep 17, 2024

btw. I also think that the name should come second and should be prefilled with the lud16 from the connection string or the getinfo call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants