fix: allow deleting last wallet #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Sep 17, 2024
| @@ -99,7 +99,15 @@ export const useAppStore = create<AppState>()((set, get) => { | |||
| const removeCurrentWallet = () => { | |||
| const wallets = [...get().wallets]; | |||
| if (wallets.length <= 1) { | |||
| // cannot delete last wallet | |||
| // set to initial wallet status | |||
There was a problem hiding this comment.
I am not sure this check is needed or if we can actually just delete the whole if?
There was a problem hiding this comment.
Wouldn't we need this check? We only do the below if it is the last wallet right?
There was a problem hiding this comment.
At the bottom is still does:
get().setSelectedWalletId(0);
set({
wallets: wallets.filter((_, i) => i !== selectedWalletId),
});
But I think there is actually a bug in the for loop - it will always not work if you try delete the wallet at the last index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Also fixes Reset. Both will now redirect the user to the
/onboardingscreen.