Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fiat currency picker #113

Merged
merged 4 commits into from
Sep 12, 2024
Merged

feat: fiat currency picker #113

merged 4 commits into from
Sep 12, 2024

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 11, 2024

image

lib/currencies.tsx Outdated Show resolved Hide resolved
@rolznz
Copy link
Contributor

rolznz commented Sep 12, 2024

@reneaaron it works nicely, I am just wondering if we need a save button now.

@reneaaron reneaaron merged commit dd69c43 into master Sep 12, 2024
1 check passed
@bumi
Copy link

bumi commented Sep 12, 2024

please coordinate with @pavanjoshi914 and make a list of our supported currencies. we don't support all.
and they need to have the correct naming. e.g. jpy vs.yen

@im-adithya im-adithya deleted the feat/currency-picker branch November 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants