Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve linking #129

Merged
merged 14 commits into from
Sep 27, 2024
Merged

fix: improve linking #129

merged 14 commits into from
Sep 27, 2024

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 17, 2024

Improves scheme handling

Improvements

Testing (and for future reference)

To simulate opens during development:

npx uri-scheme open exp://127.0.0.1:8081/--/[LIGHTNING_ADDRESS] --android
npx uri-scheme open exp://127.0.0.1:8081/--/[LNURL] --android
npx uri-scheme open exp://127.0.0.1:8081/--/[BOLT11INVOICE] --android

Test vectors

  • lightning:hello@getalby.com
  • bitcoin:bitcoinaddress?lightning=lnbc1...
  • lightning:lnurl
  • lightning:invoice

@reneaaron reneaaron force-pushed the fix/improve-linking branch 2 times, most recently from f3bfe90 to ac12662 Compare September 17, 2024 18:34
@reneaaron reneaaron added this to the 1.5 milestone Sep 17, 2024
hooks/useHandleLinking.ts Outdated Show resolved Hide resolved
hooks/useHandleLinking.ts Outdated Show resolved Hide resolved
@reneaaron reneaaron marked this pull request as ready for review September 25, 2024 09:45
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, nice changes!

@reneaaron reneaaron merged commit 52d07d2 into master Sep 27, 2024
1 check passed
@reneaaron reneaaron mentioned this pull request Oct 1, 2024
@im-adithya im-adithya deleted the fix/improve-linking branch November 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants