Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve handling for fixed amount LNURLs #133

Merged
merged 8 commits into from
Sep 25, 2024
Merged

feat: improve handling for fixed amount LNURLs #133

merged 8 commits into from
Sep 25, 2024

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 23, 2024 •
edited
Loading

Fixes #132

Testing:

  • Without comment: LNURL1DP68GURN8GHJ7ER9D4HJUMRWVF5HGUEWVDHK6TMVDE6HYMRS9A2825R5292QMLWN6N
  • With comment: LNURL1DP68GURN8GHJ7ER9D4HJUMRWVF5HGUEWVDHK6TMVDE6HYMRS9A5HJSFKGFZQYTNWTU

@reneaaron reneaaron marked this pull request as ready for review September 24, 2024 19:52
rolznz
rolznz approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron merged commit 7936aac into master Sep 25, 2024
1 check passed
@im-adithya im-adithya deleted the fix/improve-lnurl-handling branch November 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve handling of LNURLs
2 participants
@reneaaron @rolznz