Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow decimal input for fiat #140

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: allow decimal input for fiat #140

merged 1 commit into from
Sep 27, 2024

Conversation

matjaz
Copy link
Contributor

@matjaz matjaz commented Sep 26, 2024

No description provided.

@reneaaron
Copy link
Contributor

On Android the keyboard looks like this:

image

Choosing the wrong decimal separator leads to some NaN errors. Should we maybe add support for both "," and "."?

@matjaz
Copy link
Contributor Author

matjaz commented Sep 26, 2024

Comma issue is already present in released version. Simply converting , to . before calculation should do the trick.
Here are images of different keyboards https://www.lefkowitz.me/visual-guide-to-react-native-textinput-keyboardtype-options/

reneaaron
reneaaron approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit 25108f4 into getAlby:master Sep 27, 2024
1 check failed
@reneaaron reneaaron mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matjaz @reneaaron