chore: reorder and use wallet name from lud16 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this does not truly fix the root issue described in #126 which is that we shouldn't even save a new wallet until it's correctly configured. Would it be good to implement this too? |
im-adithya
commented
Oct 22, 2024
|
Just tested and it's working out great 💪 The only thing that imo should be changed is the order of steps: You start on the Connect Wallet screen where you scan a QR code. If the Connection Secret contains a LUD16 identifier that one should be used as the wallet's name, otherwise you can enter one. If you don't enter a name (or close the app) the connection should not be saved yet. |
* fix: success layout * fix: center content on screen
reneaaron
added a commit
that referenced
this pull request
Oct 31, 2024
* chore: rename animation from paid to tick * chore: reorder and use wallet anme from lud16 * chore: delete wallet on cancelling setup * fix: build error after merge * chore: convert wallet connection page to wallet setup * chore: remove trash icon * chore: remove unnecessary empty wallet logic * chore: add wallet only after setting the name * chore: set info toast position * chore: remove comment * fix: button content * fix: undo button change * fix: use button component * chore: redirect to setup if wallets.length is 0 * chore: disable button is name is empty * fix: success layout (#160) * fix: success layout * fix: center content on screen --------- Co-authored-by: René Aaron <100827540+reneaaron@users.noreply.github.com> Co-authored-by: René Aaron <rene@twentyuno.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Fixes #127
Fixes #164
Delete wallets with faulty/no NWC url (#164)
We can now select empty wallets without being redirected to setup
That makes wallet setting page accessible
Wallet can be deleted from there
Don't create wallet without valid connection string (#126)
Connect a new wallet (no. of wallets: 1)
If nwc url is invalid it doesn't create a wallet
Go back and check (no. of wallets: Still 1)
Reordering and using LUD16 (#127)
Go to setup and scan/paste nwc string
LUD 16 is used as name from string
If LUD 16 is not available
After finishing setup