feat: add lnurl withdrawal #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@im-adithya nice! what did you use for generating the two different types of vouchers? |
|
I'm using the LNURLw plugin from LNBits here (ran an instance for 21 sats, funded the wallet with NWC and installed the plugin and followed this video (make sure you install v0.1.13 otherwise it won't work)) |
reneaaron
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Nice, just did some first testing. 💪
- Min & Max amounts
If it's a dynamic amount lnurl-w (min != max) the UX currently is a bit flawed. I don't know what the min / max values are and the button is just disabled.
What if we do the on "Confirm" and display a toast with the min / max values instead? Since this also needs to be applied to the lnurl-pay flow I guess we can also do it as a follow-up:
- Linking
You already added a todo, please make sure this works as it's quite popular for different services (such as lightsats) to use the lightning:LNURLW link that just takes you to the wallet
|
Addressed ✅
For now I added code to throw error if amount is < min or > max, confirm button won't be disabled |
im-adithya
commented
Oct 21, 2024
im-adithya
commented
Oct 21, 2024
reneaaron
reviewed
Oct 22, 2024
im-adithya
commented
Oct 22, 2024
| }, | ||
|
|
||
| // LNURL-withdraw | ||
| "lightning:lnurlw123": { url: "lightning:lnurlw123", path: "/withdraw" }, |
There was a problem hiding this comment.
Ah nice, thanks @reneaaron 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Description
Adds LNURL Withdraw
Screenshots