fix: store theme in app store and secure storage #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
requested changes
Oct 29, 2024
pages/settings/Settings.tsx
Outdated
| @@ -72,7 +72,12 @@ export function Settings() { | |||
|
|
|||
| <TouchableOpacity | |||
| className="flex flex-row gap-4" | |||
| onPress={toggleColorScheme} | |||
| onPress={() => { | |||
| useAppStore | |||
There was a problem hiding this comment.
That feels wrong. Can we move this to a function in the useColorScheme hook? Also shouldn't we use setColorScheme instead of toggle? Otherwise the app store and applied theme could diverge...
There was a problem hiding this comment.
Changed toggleColorScheme to do this as well, couldn't change setColorScheme as we are using that in layout during loadTheme
reneaaron
pushed a commit
that referenced
this pull request
Oct 31, 2024
* fix: store theme in app store and secure storage * chore: fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores theme variable