Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle millisat invoices #176

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

reneaaron
Copy link
Contributor

Handle invoices with sub sats amounts.

@im-adithya
Copy link
Member

But isn't what we already have good? Instead shouldn't we change in this scenario to show 69 msats if we want to avoid decimals? Not sure if showing wrong values is good for the user although people may not even use this... wdyt?

vs

@im-adithya
Copy link
Member

We agreed on ceiling the subsat amounts, so this is good now! (slack thread)

@im-adithya im-adithya merged commit 4780898 into master Oct 30, 2024
2 checks passed
@im-adithya im-adithya deleted the fix/handle-millisats-invoices branch November 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants