New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Relay EOS check in StartSubscription #743

Closed

rolznz opened this issue Oct 21, 2024 · 0 comments · Fixed by #804

Labels

ready for implementation

Milestone

Contributor

rolznz commented Oct 21, 2024 •

edited

Loading

This check ignores any existing events which means the hub cannot handle requests it may have missed from temporary relay disconnections.

Needs testing with Alby's new NWC relay that temporarily stores undelivered events. (not deployed yet).

To test:

It should be easy to stop Alby Hub, send a request from JS SDK, then restart Alby Hub. Alby Hub should then process the request.

rolznz added this to the v1.11.0 milestone

rolznz added the ready for implementation label

rolznz mentioned this issue

fix: remove eos check after connecting to relay #804

Merged

rolznz closed this as completed in #804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment