Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove eos check after connecting to relay #804

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: remove eos check after connecting to relay #804

merged 1 commit into from
Nov 19, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 19, 2024

The eos check is not needed because:

  • The request events are ephemeral
  • When we update the relay to keep undelivered ephemeral events, only undelivered events will be consumed

Fixes #743

@rolznz rolznz requested a review from frnandu November 19, 2024 02:20
frnandu
frnandu approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit 3a25789 into master Nov 19, 2024
8 of 9 checks passed
@rolznz rolznz deleted the fix/remove-eos-check branch November 19, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frnandu frnandu frnandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Relay EOS check in StartSubscription
2 participants
@rolznz @frnandu