Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: phoenixd subwallets #1035

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat: phoenixd subwallets #1035

merged 2 commits into from
Jan 30, 2025

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 28, 2025

Closes #1034

A few users said this used to work and no longer does.

It didn't properly work because we did not set the preimage on the transaction, but it is available by looking up the invoice.

@rolznz rolznz requested a review from bumi January 28, 2025 09:17
@rolznz
Copy link
Contributor Author

rolznz commented Jan 30, 2025

@bumi I tested the changes in testnet3 sending and receiving from another node. The transaction list looks good.

@rolznz rolznz merged commit ab5310d into master Jan 30, 2025
10 checks passed
@rolznz rolznz deleted the feat/pheonixd-subwallets branch January 30, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Subwallets for Phoenixd
1 participant