feat: add transaction popup #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
commented
Jul 5, 2024
rolznz
reviewed
Jul 5, 2024
rolznz
reviewed
Jul 5, 2024
rolznz
reviewed
Jul 8, 2024
| tx: Transaction; | ||
| }; | ||
|
|
||
| function TransactionItem({ tx }: Props) { |
There was a problem hiding this comment.
We have to add a lot of dependencies (see the change to yarn.lock) and wrap every single transaction in the list with all this markup - this would not be needed if we just made a separate page to view transaction details, is it really that much better?
rolznz
reviewed
Jul 8, 2024
rolznz
reviewed
Jul 8, 2024
rolznz
reviewed
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Credenza
Desktop
Mobile