Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/lightningnetwork/lnd from 0.17.4-beta to 0.18.2-beta #246

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2024

Bumps github.com/lightningnetwork/lnd from 0.17.4-beta to 0.18.2-beta.

Release notes

Sourced from github.com/lightningnetwork/lnd's releases.

lnd v0.18.2-beta

This is a minor hot fix release that resolves an issue that arises when handling an error after attempting to broadcasting transactions if a btcd backend with an older version (pre-v0.24.2) is used.

Verifying the Release

In order to verify the release, you'll need to have gpg or gpg2 installed on your system. Once you've obtained a copy (and hopefully verified that as well), you'll first need to import the keys that have signed this release if you haven't done so already:

curl https://raw.githubusercontent.com/lightningnetwork/lnd/master/scripts/keys/roasbeef.asc | gpg --import

Once you have the required PGP keys, you can verify the release (assuming manifest-roasbeef-v0.18.2-beta.sig and manifest-v0.18.2-beta.txt are in the current directory) with:

gpg --verify manifest-roasbeef-v0.18.2-beta.sig manifest-v0.18.2-beta.txt

You should see the following if the verification was successful:

gpg: Signature made Mon Jul  8 11:04:07 2024 PDT
gpg:                using RSA key 26984CB69EB8C4A26196F7A4D7D916376026F177

That will verify the signature of the manifest file, which ensures integrity and authenticity of the archive you've downloaded locally containing the binaries. Next, depending on your operating system, you should then re-compute the sha256 hash of the archive with shasum -a 256 <filename>, compare it with the corresponding one in the manifest file, and ensure they match exactly.

Verifying the Release Timestamp

From this new version onwards, in addition time-stamping the git tag with OpenTimestamps, we'll also now timestamp the manifest file along with its signature. Two new files are now included along with the rest of our release artifacts: manifest-roasbeef-v0.18.2-beta.txt.asc.ots.

Assuming you have the opentimestamps client installed locally, the timestamps can be verified with the following commands:

ots verify manifest-roasbeef-v0.18.2-beta.sig.ots -f manifest-roasbeef-v0.18.2-beta.sig

Alternatively, the OpenTimestamps website can be used to verify timestamps if one doesn't have a bitcoind instance accessible locally.

These timestamps should give users confidence in the integrity of this release even after the key that signed the release expires.

Verifying the Release Binaries

Our release binaries are fully reproducible. Third parties are able to verify that the release binaries were produced properly without having to trust the release manager(s). See our reproducible builds guide for how this can be achieved. The release binaries are compiled with go1.22.3, which is required by verifiers to arrive at the same ones. They include the following build tags: autopilotrpc, signrpc, walletrpc, chainrpc, invoicesrpc, neutrinorpc, routerrpc, watchtowerrpc, monitoring, peersrpc, kvdb_postrgres, kvdb_etcd and kvdb_sqlite. Note that these are already included in the release script, so they do not need to be provided.

The make release command can be used to ensure one rebuilds with all the same flags used for the release. If one wishes to build for only a single platform, then make release sys=<OS-ARCH> tag=<tag> can be used.

Finally, you can also verify the tag itself with the following command:

</tr></table> 

... (truncated)

Commits
  • d22b393 Merge pull request #8901 from ellemouton/0-18-2-fix
  • 53b07eb build: bump version to v0.18.2-beta
  • e0c924b docs: update release notes
  • cffb6e8 lnwallet: fix ErrDoubleSpend
  • a2238e9 multi: update RPC error import path
  • 77a4a32 multi: use chain.MapRPCErr instead of rpcclient.MapRPCErr
  • e3687b6 gomod: update btcwallet to include RPC errors
  • 42b856d Merge pull request #8866 from ellemouton/0-18-1-fix
  • f695451 build: bump version to v0.18.1-beta
  • 362182b docs: update release notes for 0.18.1-beta
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/lightningnetwork/lnd](https://github.com/lightningnetwork/lnd) from 0.17.4-beta to 0.18.2-beta.
- [Release notes](https://github.com/lightningnetwork/lnd/releases)
- [Changelog](https://github.com/lightningnetwork/lnd/blob/master/docs/release.md)
- [Commits](lightningnetwork/lnd@v0.17.4-beta...v0.18.2-beta)

---
updated-dependencies:
- dependency-name: github.com/lightningnetwork/lnd
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 10, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 12, 2024

A newer version of github.com/lightningnetwork/lnd exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@im-adithya
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 14, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@im-adithya
Copy link
Member

The replacement of glebarez/sqlite package with driver/sqlite was done because we were using glebarez/sqlite for it's lightweight pure-go implementation. But some of our dependencies already require c compiler (github.com/breez/breez-sdk-go/breez_sdk, github.com/getAlby/glalby-go/glalby, github.com/getAlby/ldk-node-go/ldk_node)

And glebarez/sqlite is mainly replaced because it is causing an issue with the new lnd version because now lnd also registers a db with modernc.org/sqlite and glebarez/sqlite also uses the same dependency internally, causing the sql init function to be called twice with the same driver name.

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

It would be good if @bumi can review too.

@rolznz
Copy link
Contributor

rolznz commented Aug 16, 2024

causing the sql init function to be called twice with the same driver name.

@im-adithya where is this?

@rolznz rolznz merged commit 293e4cc into master Aug 17, 2024
8 checks passed
@rolznz rolznz deleted the dependabot/go_modules/github.com/lightningnetwork/lnd-0.18.2-beta branch August 17, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants