Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render.com phoneixd #280

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Render.com phoneixd #280

merged 3 commits into from
Jul 19, 2024

Conversation

bumi
Copy link
Contributor

@bumi bumi commented Jul 15, 2024

This makes finding the matching phoneixd in cloud environments easier. we default to http if that is not privided

bumi added 3 commits July 15, 2024 22:26
some environments can only provide the host and port for internal services (e.g. render.com)
in those cases we default to http
This allows one click deploys to render.com with a phoenixd backend
@bumi bumi marked this pull request as ready for review July 19, 2024 10:02
@bumi bumi requested a review from rolznz July 19, 2024 10:03
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit a137474 into master Jul 19, 2024
8 checks passed
@rolznz rolznz deleted the render-phoneixd branch July 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants