feat: add channel alerts in send and receive pages #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Jul 17, 2024
rolznz
reviewed
Jul 18, 2024
rolznz
reviewed
Jul 18, 2024
Good question, I think we should have a specific alert for this on the main wallet page, and not allow the user to enter the send or receive pages (If the LNClient has channel management and the user has no channels) |
rolznz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
What if the user doesn't have any channels? Should we hide the Send/Receive buttons from the Wallet screen
Send
Receive