feat: reconnect immediately on first retry #338
Conversation
|
@im-adithya please re-read the issue and think through it. If you don't understand it, please do ask before writing code |
im-adithya
force-pushed
the
task-connect-relay
branch
from
89e91c4
to
8de476a
Compare
im-adithya
changed the title
|
@rolznz can you re-review? |
service/start.go
Outdated
| @@ -63,6 +64,8 @@ func (svc *service) startNostr(ctx context.Context, encryptionKey string) error | |||
| if contextCancelled { | |||
| break | |||
| } | |||
| } else if i > 0 { | |||
There was a problem hiding this comment.
I think this if-else with checking the i value makes things over-complicated. I don't think we need to check the iteration at all now since we now control whether we back off or not.
service/start.go
Outdated
| @@ -46,10 +46,11 @@ func (svc *service) startNostr(ctx context.Context, encryptionKey string) error | |||
| defer svc.wg.Done() | |||
| //Start infinite loop which will be only broken by canceling ctx (SIGINT) | |||
| var relay *nostr.Relay | |||
| immediateRetry := false | |||
There was a problem hiding this comment.
I think it'd be easier to understand to flip this and call it waitToReconnectSeconds, and use a number instead of a boolean, so that later we are able to easily adjust the algorithm (e.g. do an exponential back off algorithm)
service/start.go
Outdated
|
|
||
| for i := 0; ; i++ { | ||
| // wait for a delay before retrying except on first iteration | ||
| if i > 0 { | ||
| if i > 0 && !immediateRetry { |
There was a problem hiding this comment.
I would remove the iteration check here and do if waitToReconnectSeconds > 0
|
@im-adithya can you address the feedback? |
|
Ready now @rolznz! |
Fixes #297
Is this what we want here @rolznz?