Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no default invoice memo #359

Merged
merged 1 commit into from
Jul 29, 2024
Merged

chore: no default invoice memo #359

merged 1 commit into from
Jul 29, 2024

Conversation

bumi
Copy link
Contributor

@bumi bumi commented Jul 27, 2024

what value does it give? then all the entries say lightning invoice and it can only be a lightning invoice

what value does it give? then all the entries say lightning invoice
and it can only be a lightning invoice
@rolznz
Copy link
Contributor

rolznz commented Jul 28, 2024

I see, this is especially wrong for keysend payments.

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron merged commit 4a41462 into master Jul 29, 2024
7 of 8 checks passed
@reneaaron reneaaron deleted the no-default-memo branch July 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants