Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not allow duplicate getalby.com apps #362

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jul 29, 2024

No description provided.

@rolznz rolznz requested review from bumi and reneaaron July 29, 2024 06:12
@@ -396,6 +396,11 @@ func (svc *albyOAuthService) GetAuthUrl() string {
}

func (svc *albyOAuthService) LinkAccount(ctx context.Context, lnClient lnclient.LNClient, budget uint64, renewal string) error {
appName := "getalby.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if I create one and call it like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be 🐉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bumi I will merge this, I think it's the best way for now

@rolznz rolznz merged commit 4d50a98 into master Jul 29, 2024
8 checks passed
@rolznz rolznz deleted the fix/duplicate-getalbycom-app branch July 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants