Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA Configuration #393

Merged
merged 5 commits into from
Aug 7, 2024
Merged

PWA Configuration #393

merged 5 commits into from
Aug 7, 2024

Conversation

jsahagun91
Copy link
Contributor

No description provided.

@rolznz
Copy link
Contributor

rolznz commented Aug 3, 2024

Thanks for the PR @jsahagun91 !

@rolznz rolznz requested review from im-adithya and reneaaron August 3, 2024 07:42
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@jsahagun91 thanks!

FYI - there were some things incorrect especially for ios, and no manual manifest.json is needed (it's injected by the plugin).

@rolznz rolznz merged commit 5873264 into getAlby:master Aug 7, 2024
1 check passed
@jsahagun91
Copy link
Contributor Author

@rolznz thank you! I will take a look and continue to learn 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants