Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: process podcasting custom key/value records #443

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

bumi
Copy link
Contributor

@bumi bumi commented Aug 11, 2024

Fixes #437

This loads the app for a keysend transaction from the custom key/value data.

it is using the app ID as costum value - the nostr key of the connection is a bit more private than the app id of the hub

This loads the app for a keysend transaction from the custom key/value
data.

it is using the app ID as costum value - the nostr key of the connection
is a bit more private than the app id of the hub
@bumi bumi marked this pull request as draft August 11, 2024 18:57
@rolznz rolznz added this to the v1.5.0 milestone Aug 12, 2024
@rolznz rolznz changed the title feat: process podcastig custom key/value records feat: process podcasting custom key/value records Aug 12, 2024
extract the custom records lookup in a special function
@rolznz rolznz marked this pull request as ready for review August 12, 2024 07:02
@bumi bumi requested a review from rolznz August 12, 2024 07:03
to easier handle nil values
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit 346ad55 into master Aug 12, 2024
7 of 8 checks passed
@rolznz rolznz deleted the feat/process-podcasting-custom-key-value branch August 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support keysend customKey/customValue for isolated apps
2 participants