Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace instances of window alert and confirm #458

Merged
merged 14 commits into from
Aug 22, 2024

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Aug 12, 2024

Fixes #419
Fixes #514

Todos

Alert to Toast

Screenshot 2024-08-15 at 12 50 01 AM Screenshot 2024-08-15 at 12 52 11 AM

Unlink Dialog

Screenshot 2024-08-15 at 12 54 00 AM

Debug Tools Dialogs

Screenshot 2024-08-15 at 1 18 48 AM Screenshot 2024-08-15 at 1 19 11 AM Screenshot 2024-08-15 at 1 19 25 AM Screenshot 2024-08-15 at 1 19 47 AM

Routing Data shifted to Debug Tools (LDK only)

Screenshot 2024-08-15 at 1 20 04 AM

Restore Node Alert Dialog

Screenshot 2024-08-15 at 1 21 27 AM

@im-adithya im-adithya changed the title Task window methods chore: replace instances of window alert and confirm Aug 12, 2024
@im-adithya im-adithya requested a review from rolznz August 14, 2024 19:55
@im-adithya im-adithya marked this pull request as ready for review August 14, 2024 19:56
@rolznz rolznz added this to the v1.6.0 milestone Aug 17, 2024
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz
Copy link
Contributor

rolznz commented Aug 22, 2024

Nice work @im-adithya !

@rolznz rolznz merged commit 4674ee3 into master Aug 22, 2024
7 of 8 checks passed
@rolznz rolznz deleted the task-window-methods branch August 22, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants