feat: show pending payments in transactions list #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Aug 31, 2024
| @@ -474,7 +474,7 @@ func (svc *transactionsService) LookupTransaction(ctx context.Context, paymentHa | |||
| return &transaction, nil | |||
| } | |||
|
|
|||
| func (svc *transactionsService) ListTransactions(ctx context.Context, from, until, limit, offset uint64, unpaid bool, transactionType *string, lnClient lnclient.LNClient, appId *uint) (transactions []Transaction, err error) { | |||
| func (svc *transactionsService) ListTransactions(ctx context.Context, from, until, limit, offset uint64, pending, unpaid bool, transactionType *string, lnClient lnclient.LNClient, appId *uint) (transactions []Transaction, err error) { | |||
There was a problem hiding this comment.
this introduces another bool and now there is the complexity you see below.
What about we have a stateTypes which and use that. the default would be []string{"TRANSACTION_STATE_SETTLED"}
There was a problem hiding this comment.
But this is problematic because we only want to see pending outgoing payments. This needs more thought. Maybe a function that can alter the query could be passed in 🤔 This will also be a problem for NWC though.
There was a problem hiding this comment.
This is more complicated than I thought, let's move it to the next milestone
|
Closing in favor of #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
Currently needs design input, didn't add much there as it would result in conflicts with Roland's (upcoming?) transaction list changes in #570