-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: withdraw custom amount from savings #597
Conversation
</Alert> | ||
)} | ||
{!!balances?.onchain.reserved && | ||
(sendAll || +amount > balances.onchain.total * 0.9) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use spendable instead of total
btw. I find this screen a bit too complicated and I have never seen a wallet where I need to confirm my address and check a box. why does it actually need to be that I am the owner of that address and having the seed phrase of it? |
<Input | ||
id="amount" | ||
type="number" | ||
value={sendAll ? balances.onchain.total : amount} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure "send all" will be that amount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, good catch!
@bumi this was because one of our users sent their funds to the wrong address 😢 I'll update the copy a bit. Update: replaced with confirmation dialog |
that's a nice UI. |
Closes #575
This allows users to send explicit amounts, e.g. to do a boltz swap, but is kept in the advanced options as Alby Hub is primarily a lightning wallet.
In the withdraw page, an input and send all checkbox are added. Because of how transaction fee calculation in bitcoin works, send all vs sending an amount are two different actions. The user is also warned if they send all when they have channels open, as it will drain their anchor reserves.