feat: alby go app #674
Merged
feat: alby go app #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Sep 20, 2024
frontend/src/screens/Home.tsx
Outdated
| @@ -77,6 +78,34 @@ function Home() { | |||
| </Card> | |||
| </ExternalLink> | |||
| )} | |||
|
|
|||
| <ExternalLink to="https://www.albygo.com"> | |||
There was a problem hiding this comment.
Should this go to /internal-apps/alby-go ?
bumi
reviewed
Sep 20, 2024
| <ul className="list-inside list-decimal"> | ||
| <li>Download the app from the app store</li> | ||
| <li> | ||
| Create a new app connection for Alby Go by clicking on{" "} |
There was a problem hiding this comment.
"by clicking" sounds a bit strange.
can this not be just a button/link ? "Create a new app connection for Alby Go"
rolznz
reviewed
Sep 20, 2024
| } | ||
| description="" | ||
| contentRight={ | ||
| <Link to={`/apps/new?app=${app?.id}`}> |
There was a problem hiding this comment.
Ideally we just show a qr code on the screen when you press this button rather than linking, so the user doesn't have to see all the wallet permissions options. But maybe we can do this as a second iteration
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would actually be quite easy to create a dynamic page with some fallback (for the "how to connect" section) that does the same thing for all available apps. Not sure if we should take this other step right away, wdyt?