chore: use slashed zero and sensitive #708
Conversation
| @@ -33,7 +33,7 @@ function BalanceCard({ | |||
| <BalanceCardIcon className="h-4 w-4 text-muted-foreground" /> | |||
| </CardHeader> | |||
| <CardContent> | |||
| <div className="text-2xl font-bold balance sensitive"> | |||
| <div className="text-2xl font-bold balance sensitive slashed-zero"> | |||
There was a problem hiding this comment.
is sensitive required? we added posthog only temporarily for initial testing. It's already been removed.
There was a problem hiding this comment.
Ah, so then should I remove sensitive from other places too?
There was a problem hiding this comment.
@bumi do you think we still need this classname?
There was a problem hiding this comment.
does that hurt?
tailwind likes classes. and actually that one is the most descriptive one of them :)
| @@ -222,7 +222,7 @@ function AppInternal({ app, refetchApp, capabilities }: AppInternalProps) { | |||
| <CardHeader> | |||
| <CardTitle>Info</CardTitle> | |||
| </CardHeader> | |||
| <CardContent> | |||
| <CardContent className="slashed-zero"> | |||
There was a problem hiding this comment.
can you be more precise where you add it? this adds the classname to all child elements
There was a problem hiding this comment.
I wanted the Dates and Pubkey etc to also have a slashed zero, so I applied it to the parent like we did in the DialogTrigger in TransactionItem
Adds slashed-zeros everywhere we use amounts and sensitive where we reveal balances (onchain and lightning) and invoice amounts (i.e. only in transactions list)