Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use actual error objects in NWC Client #209

Merged
merged 7 commits into from
Mar 6, 2024
Merged

fix: use actual error objects in NWC Client #209

merged 7 commits into from
Mar 6, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Feb 29, 2024 •
edited
Loading

@bumi
Copy link
Contributor

bumi commented Mar 2, 2024

How about we introduce some more error classes depending on when the error happens.?

e.g.
Timeout error,
wallet error,

those inherit from the nip47 error but are a bit more specific. then as a developer I can easily catch the specific type or error

@rolznz
Copy link
Contributor Author

rolznz commented Mar 5, 2024

@bumi I've added some more error classes, could you have another look?

bumi
bumi approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rolznz rolznz merged commit 5e77025 into master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi bumi approved these changes

@im-adithya im-adithya Awaiting requested review from im-adithya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolznz @bumi