chore: try to fix specs (#2401)

getAlby · May 6, 2023 · b218397 · b218397
1 parent 573d102
commit b218397
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 10 deletions.
diff --git a/tests/e2e/001-createWallets.spec.ts b/tests/e2e/001-createWallets.spec.ts
@@ -148,13 +148,22 @@ test.describe("Create or connect wallets", () => {
     await browser.close();
   });
 
-  test("successfully connects to Umbrel", async () => {
+  test("successfully connects to Umbrel LND", async () => {
     const { browser, page, $document } = await createNewWalletWithPassword({
       openConnectOtherWallet: true,
     });
 
     const connectButton = await getByText($document, "Umbrel");
-    connectButton.click();
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      connectButton.click()
+    ]);
+
+    const lndButton = await getByText($document, "Lightning Node");
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      lndButton.click()
+    ]);
 
     // wait for the field label instead of headline (headline text already exists on the page before)
     await findByText($document, "lndconnect REST URL");
@@ -172,13 +181,22 @@ test.describe("Create or connect wallets", () => {
     await browser.close();
   });
 
-  test("successfully connects to myNode", async () => {
+  test("successfully connects to myNode LND", async () => {
     const { browser, page, $document } = await createNewWalletWithPassword({
       openConnectOtherWallet: true,
     });
 
     const connectButton = await getByText($document, "myNode");
-    connectButton.click();
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      connectButton.click()
+    ]);
+
+    const lndButton = await getByText($document, "LND");
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      lndButton.click()
+    ]);
 
     // wait for the field label instead of headline (headline text already exists on the page before)
     await findByText($document, "lndconnect REST URL");
@@ -202,7 +220,16 @@ test.describe("Create or connect wallets", () => {
     });
 
     const connectButton = await getByText($document, "Start9");
-    connectButton.click();
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      connectButton.click()
+    ]);
+
+    const lndButton = await getByText($document, "LND");
+    await Promise.all([
+      page.waitForNavigation(), // The promise resolves after navigation has finished
+      lndButton.click()
+    ]);
 
     // wait for the field label instead of headline (headline text already exists on the page before)
     await findByText($document, "lndconnect REST URL");

diff --git a/tests/e2e/helpers/loadExtension.ts b/tests/e2e/helpers/loadExtension.ts
@@ -120,11 +120,11 @@ export const createNewWalletWithPassword = async (options?: {
 export const commonCreateWalletSuccessCheck = async ({ page, $document }) => {
   // submit form
   const continueButton = await findByText($document, "Continue");
-  continueButton.click(),
-    // options.html
-    await Promise.all([
-      page.waitForNavigation(), // The promise resolves after navigation has finished
-    ]);
+  continueButton.click();
+  // options.html
+  await Promise.all([
+    page.waitForNavigation(), // The promise resolves after navigation has finished
+  ]);
 
   // options.html#publishers
   await Promise.all([