Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement stablesats for galoy connector #2730

Open
reneaaron opened this issue Sep 6, 2023 · 1 comment
Open

[Feature] Implement stablesats for galoy connector #2730

reneaaron opened this issue Sep 6, 2023 · 1 comment
Labels
idea A feature idea that needs to be more specification

Comments

@reneaaron
Copy link
Contributor

Feature description

Allow users to use their stablesats accounts in Alby.

Alby already allows adding fiat-denominated accounts, although users will currently need to add multiple accounts to Alby because currency can only be set on account level.

Steps

  • Allow users to select their account during account addition
  • Change the connector to support fiat-denominated account configs
  • Change the requests to the GraphQR endpoint so they use the right wallet

Describe the solution

Reference implementation

Describe alternatives

No response

Additional context

No response

Are you working on this?

None
@reneaaron reneaaron added the idea A feature idea that needs to be more specification label Sep 6, 2023
@openoms
Copy link
Contributor

openoms commented Feb 7, 2024

Heads up: Galoy offers a 1million sats bounty for this feature to be implemented. Details at: GaloyMoney/blink#3950

@openoms openoms mentioned this issue Feb 7, 2024
Open
1 task
riccardobl added a commit to riccardobl/lightning-browser-extension that referenced this issue Feb 8, 2024
@riccardobl
feat: implement stablesats for galoy connector getAlby#2730
65fb7eb
@riccardobl riccardobl mentioned this issue Feb 8, 2024
Merged
9 tasks
riccardobl added a commit to riccardobl/lightning-browser-extension that referenced this issue Feb 20, 2024
@riccardobl
feat: implement stablesats for galoy connector getAlby#2730 getAlby#3020
3f16ef5
riccardobl added a commit to riccardobl/lightning-browser-extension that referenced this issue Feb 22, 2024
@riccardobl
feat: implement stablesats for galoy connector getAlby#2730
b7cad44
riccardobl added a commit to riccardobl/lightning-browser-extension that referenced this issue Feb 22, 2024
@riccardobl
feat: implement stablesats for galoy connector getAlby#2730
e91d466
reneaaron added a commit that referenced this issue Mar 14, 2024
@riccardobl @reneaaron
feat: implement stablesats for galoy connector #2730 (#3020)
186ec4b 
* feat: implement stablesats for galoy connector  #2730

* fix: galoy connector defaults to BTC currency, create sats denominated usd invoices, fix naming

* fix: disable amount check for non btc balances

* fix: remove obsolete code

* fix: create helper for parsing invoices

---------

Co-authored-by: René Aaron <100827540+reneaaron@users.noreply.github.com>
Co-authored-by: René Aaron <rene@twentyuno.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea A feature idea that needs to be more specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@openoms @reneaaron