Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LNC typings #2844

Closed
reneaaron opened this issue Nov 6, 2023 · 1 comment · Fixed by #2847
Closed

Add LNC typings #2844

reneaaron opened this issue Nov 6, 2023 · 1 comment · Fixed by #2847
Labels
idea A feature idea that needs to be more specification

Comments

@reneaaron
Copy link
Contributor

Feature description

LNC is currently used as an FixMe type, which prevents our tooling from catching errors.

https://github.com/getAlby/lightning-browser-extension/blob/feat/transaction-list/src/extension/background-script/connectors/lnc.ts#L159

Describe the solution

Using types provided by the LNC library.

Describe alternatives

No response

Additional context

No response

Are you working on this?

None
@reneaaron reneaaron added the idea A feature idea that needs to be more specification label Nov 6, 2023
@rolznz
Copy link
Contributor

rolznz commented Nov 6, 2023

Also LNC method casings and parameters have changed, and the Alby integration could break when the package is updated.

@reneaaron reneaaron mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea A feature idea that needs to be more specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: LNC typings getAlby/lightning-browser-extension
2 participants
@rolznz @reneaaron