Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LNC typings #2847

Merged
merged 21 commits into from
Mar 13, 2024
Merged

fix: LNC typings #2847

merged 21 commits into from
Mar 13, 2024

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Fixes #2844

@reneaaron reneaaron self-assigned this Nov 6, 2023

This comment was marked as outdated.

@reneaaron reneaaron added the next-release To be included in the next release label Dec 20, 2023
Copy link

socket-security bot commented Mar 12, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@reneaaron reneaaron marked this pull request as ready for review March 13, 2024 09:47
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have lnc node to test this? code wise lgtm

@reneaaron
Copy link
Contributor Author

do we have lnc node to test this? code wise lgtm

I don't think so, I've tested it with my own one.

@reneaaron reneaaron enabled auto-merge (squash) March 13, 2024 12:49
@reneaaron reneaaron merged commit db84635 into master Mar 13, 2024
6 checks passed
@reneaaron reneaaron deleted the fix/lnc-typings branch March 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LNC typings
2 participants