Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify transaction types #2846

Open
3 tasks
reneaaron opened this issue Nov 6, 2023 · 0 comments
Open
3 tasks

Simplify transaction types #2846

reneaaron opened this issue Nov 6, 2023 · 0 comments
Labels
idea A feature idea that needs to be more specification

Comments

@reneaaron
Copy link
Contributor

Feature description

  • Try to get rid of the Invoice type
  • Remove on of memo vs. title (which are the same)
  • tackle overlaps of types, e.g. payment_hash and paymentHash, maybe map explicitly instead of ...) - not a problem in terms of TS types, but the resulting JS object contains all fields (e.g. when you console.log it)

Describe the solution

Describe alternatives

No response

Additional context

No response

Are you working on this?

None
@reneaaron reneaaron added the idea A feature idea that needs to be more specification label Nov 6, 2023
@reneaaron reneaaron mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea A feature idea that needs to be more specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reneaaron