feat: transaction list revamp #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup hooks and use single hook to get transactions cleanup allowanceview, homeview and publisher card view to adapt transaction list changes add mechanism to sort, db payments and invoices signed-off-by: pavan joshi <pavanjoshi914@gmail.com>
color sats word in transaction table using regex
pavanjoshi914
force-pushed
the
feat/transaction-list
branch
from
f44a241
to
ce2980e
Compare
|
@pavanjoshi914 I get some NaN sats transactions |
|
@pavanjoshi914 can you please update the PR description and link to a ticket? |
|
Arrow icons do not match the figma (sizing and thickness), can they be updated? |
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
rolznz
reviewed
Sep 26, 2023
unable to reproduce this on my side. kindly check in production |
bitcoin designs has only those icon, we need custom fat arrow icons if we want the icon similar to design. i didn't put much priority on icons currently |
setup callback communication minor naming corrections shift publisher link in the transaction modal correct variable names, show total fees in form of formatted sats signed-off-by: pavan joshi <pavanj914@gmail.com>
Other connectors currently have no support for displaying transactions. |
reneaaron
commented
Oct 31, 2023
…ghtning-browser-extension into feat/transaction-list
remove exposure of getInvoices via api fix broken show more button for lndhub signed-off-by: pavan joshi <pavanj914@gmail.com>
rolznz
reviewed
Nov 3, 2023
rolznz
reviewed
Nov 3, 2023
rolznz
reviewed
Nov 3, 2023
rolznz
reviewed
Nov 3, 2023
rolznz
reviewed
Nov 3, 2023
rolznz
reviewed
Nov 3, 2023
|
TODO
Follow-ups
|
remove unnecessary types at connectorlevel add proper types for internal methods cleanup connector getInvoices method which don't have getTransactions method
|
tACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
transaction list revamp
Design
https://www.figma.com/file/IvlUHnC3vkIWnQ14FppZqT/%F0%9F%8E%A8-Extension-UI-revamp?node-id=101%3A62629&mode=dev