Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed buttons in github battery #1443

Closed
wants to merge 1 commit into from

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Adds a button to the GitHub page to make tipping more evident.

Link this PR to an issue

#1442

Type of change (Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes (If any)

Screenshot from 2022-09-14 11-24-51

How has this been tested?

Tested Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: null (who recently dropped 210 sats):

Checkout the Alby Lightning Mixtape: https://alby-mixtape.vercel.app - happy coding!

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep stacking sats!

@im-adithya im-adithya requested review from bumi, reneaaron and escapedcat and removed request for bumi September 14, 2022 06:12
@escapedcat
Copy link
Contributor

In general I like this a lot. If we add more such buttons we should extract that button code somehow.

@im-adithya
Copy link
Member Author

Closing in favor of "The Boost Button" #1939

@im-adithya im-adithya closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants