Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test code for DefaultView #2160

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

qqqzhch
Copy link
Contributor

@qqqzhch qqqzhch commented Mar 2, 2023

Describe the changes you have made in this PR

add test code for DefaultView

Type of change

(Remove other not matching type)

  • test: Test code update

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@qqqzhch
Copy link
Contributor Author

qqqzhch commented Mar 2, 2023

@escapedcat
I'm adding some test-related code that
component with two more parameters.
I don't know how to trigger the incoming parameters in the wallet, and what the page looks like, can you take a screenshot for me?

export type Props = {
  lnDataFromCurrentTab?: Battery[];
  currentUrl: URL | null;
};

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@rolznz
Copy link
Contributor

rolznz commented Mar 3, 2023

@escapedcat I'm adding some test-related code that component with two more parameters. I don't know how to trigger the incoming parameters in the wallet, and what the page looks like, can you take a screenshot for me?

export type Props = {
  lnDataFromCurrentTab?: Battery[];
  currentUrl: URL | null;
};

I am not sure I understand the question, but you can make a new test that passes these props to DefaultView <DefaultView currentUrl={TODO} lnDataFromCurrentTab={TODO} />

Based on what site you are on data will be provided from a battery, right? I think you could visit a site like github or youtube and go to a profile/channel of someone that added a lightning address (I think some examples are here: #1939) and debug/log what is passed to this component.

@qqqzhch
Copy link
Contributor Author

qqqzhch commented Mar 4, 2023

@escapedcat I'm adding some test-related code that component with two more parameters. I don't know how to trigger the incoming parameters in the wallet, and what the page looks like, can you take a screenshot for me?

export type Props = {
  lnDataFromCurrentTab?: Battery[];
  currentUrl: URL | null;
};

I am not sure I understand the question, but you can make a new test that passes these props to DefaultView <DefaultView currentUrl={TODO} lnDataFromCurrentTab={TODO} />

Based on what site you are on data will be provided from a battery, right? I think you could visit a site like github or youtube and go to a profile/channel of someone that added a lightning address (I think some examples are here: #1939) and debug/log what is passed to this component.

Okay, I'll take a look at the examples #1939 and learn the logic of this

@qqqzhch qqqzhch marked this pull request as ready for review March 6, 2023 12:55
@bumi bumi requested a review from im-adithya March 6, 2023 22:14
@im-adithya im-adithya disabled auto-merge June 19, 2023 18:01
@im-adithya im-adithya merged commit 197538f into getAlby:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants