-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update websites.json: add a Nostr client #2182
Conversation
@BlowaterNostr Thanks for the PR! I just wanted to test this application but stumbled upon this hint: Do you mind to explain what isn't working for you in Firefox? |
@reneaaron Will reproduce and give you a better report. |
@BlowaterNostr Cool, thanks! 🙌 Feel free to open a new issue for that 👍 |
Maybe it's not necessarily a bug of Alby. But the way my application is interacting with it. The direct observation is that Using Alby on Firefox with Blowater will trigger a null reference exception very deep in Preact's code with no call stack from application code. With the same code, but Chrome works. |
Okay. Is the code available publicly? Happy to take a quick look... |
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
@reneaaron the code is not open sourced yet. I will consider it once it reaches feature stability. |
@reneaaron I have found the reason and it's a good indicator that Alby should support concurrent API calls or at least throw errors when user concurrently calls. The story is this, in Blowater, we concurrently call
are called in the same tick. I worked around this problem by adding a queue in my application code to wait for the previous call to resolve before invoking the next. But, because Blowater also use IndexedDB, therefore, wrong data (should be an event, but was Fundamentally, TS is not type safe when it comes to serialize raw JSON to objects. Therefore, if application code always do type check during de serialization at runtime, this bug can be prevented. But this is not the norm in TS/JS code. The communicate between extension and application is similar to serialization because it's also across program boundaries. We need better type safety here. On Alby side, it should not return incorrect data (silent error) even if concurrent call is not allowed. Throwing exceptions is acceptable if concurrent call needs more time to design. |
@BlowaterNostr Thanks for this detailed report, we're looking into it! I'll get back to you as soon as we have a fix for it ready to test👌 |
#2218 does not block the development of my client, can we merge this first? @reneaaron |
Since #2218 is just merged, can we merge this now? |
Blowater isn’t showing up. Is this because the action failed? |
@BlowaterNostr you might stil be on the old version. |
Describe the changes you have made in this PR
Add https://blowater.deno.dev/ to Nostr website page
Type of change
docs
: Documentation update