Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Websites): add loading spinner #2211

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

lujakob
Copy link
Contributor

@lujakob lujakob commented Mar 14, 2023

Describe the changes you have made in this PR

Add loading spinner to websites page

Link this PR to an issue [optional]

Fixes #2210

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

Bildschirmfoto 2023-03-14 um 13 05 22

How has this been tested?

Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@lujakob
Copy link
Contributor Author

lujakob commented Mar 14, 2023

@escapedcat @reneaaron fyi

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Thanks @lujakob! 🙌

@escapedcat escapedcat merged commit 350bb93 into getAlby:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add websites pages loading spinner
3 participants